[do not merge]Retain documentElement when appending/removing from Document #24524
+177
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating a root or hydrating into a root with a Document container could error in surprising ways because the document root element was not removed when clearing the container and then a new html element was attempting to be appended to the document. Browsers do not allow more than one root element and this errored leading to a cascading failure where all content was unmounted from the tree breaking the application. This change changes the behavior of clearContainer, appendChildToContainer, and removeChildFromContainer clearContainer on a Document container will now remove all children of the documentElement (usually <html>) appendChildToContainer on a Document container will now 'adopt' the existing documentElement, transferring all stateNode properties and children over to it rather than dirctly appending the child removeChildFromContainer on a Document container will now remove all children of the documentElement but leave the documentElement in place
|
Comparing: 99eef9e...1818f29 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
closing in favor of #24523 which is less code and more semantically correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creating a root or hydrating into a root with a Document container could error in surprising ways because the document root element was not removed when clearing the container and then a new html element was attempting to be appended to the document. Browsers do not allow more than one root element and this errored leading to a cascading failure where all content was unmounted from the tree breaking the application.
This change changes the behavior of clearContainer, appendChildToContainer, and removeChildFromContainer
clearContainer on a Document container will now remove all children of the documentElement (usually )
appendChildToContainer on a Document container will now 'adopt' the existing documentElement, transferring all stateNode properties and children over to it rather than dirctly appending the child
removeChildFromContainer on a Document container will now remove all children of the documentElement but leave the documentElement in place
Summary
How did you test this change?